[PATCH] D69775: [Scheduling][ARM] Consistently enable PostRA Machine scheduling

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 02:49:58 PST 2019


samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:389
+  // Don't reschedule potential IT blocks.
+  return !isThumb1Only();
+}
----------------
I know this is the existing logic, but what are we trying to do here with respect to IT blocks? If we're worried about IT blocks, like the comment suggests, shouldn't we be returning isThumb1Only()? Also, if we're in arm mode then we won't have them, but are we still concerned about predicated instructions (I assume not)? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69775/new/

https://reviews.llvm.org/D69775





More information about the llvm-commits mailing list