[PATCH] D69660: [HardwareLoops] Optimisation remarks

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

Confirmed internal crash fixed with the dependancy decl change.

Now only one test case fail:

  : 'RUN: at line 2';   /home/czhengsz/llvm_new/llvm-project/llvm/build/bin/llc -mtriple=thumbv8.1m.main-arm-none-eabi /home/czhengsz/llvm_new/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/structure.ll -o - -pass-remarks-analysis=hardware-loops  2>&1 | /home/czhengsz/llvm_new/llvm-project/llvm/build/bin/FileCheck /home/czhengsz/llvm_new/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/structure.ll --check-prefix=CHECK-LLC
  
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/czhengsz/llvm_new/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/structure.ll:181:14: error: CHECK-LLC: expected string not found in input
  ; CHECK-LLC: remark: <unknown>:0:0: hardware-loop not created: loop is not a candidate
               ^
  <stdin>:90:10: note: scanning from here
  .LBB1_5: @ %while.end7
           ^

Strange thing is that it only fails on PowerPC but ok on ARM, this is a ARM case?

I think you can not mixup checking for remark and assembly both based on `CHECK-LLC`. All remarks will be put in the front of the output and after checking assembly with `CHECK-LLC` in func `nested`, there is no any remark logs after.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69660/new/

https://reviews.llvm.org/D69660