[PATCH] D69774: [APFloat] Add support for operations on Signaling NaN
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 3 13:15:40 PST 2019
arsenm added inline comments.
================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:1758
APFloat QNaN = APFloat::getNaN(APFloat::IEEEsingle(), false);
- APFloat SNaN = APFloat::getSNaN(APFloat::IEEEsingle(), false);
+ APFloat SNaN = APFloat(APFloat::IEEEsingle(), "snan1");
APFloat PNormalValue = APFloat(APFloat::IEEEsingle(), "0x1p+0");
----------------
Why the 1?
================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:1784
{ PInf, QNaN, "nan", APFloat::opOK, APFloat::fcNaN },
-#if 0
- // See Note 1.
- { PInf, SNaN, "nan", APFloat::opInvalidOp, APFloat::fcNaN },
-#endif
+ { PInf, SNaN, "nan1", APFloat::opInvalidOp, APFloat::fcNaN },
{ PInf, PNormalValue, "inf", APFloat::opOK, APFloat::fcInfinity },
----------------
Why the 1?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69774/new/
https://reviews.llvm.org/D69774
More information about the llvm-commits
mailing list