[PATCH] D69228: [LV] Generalize conditions for sinking instrs for first order recurrences.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:732
 
-  return true;
+  return allUsesDominatedBy(Phi, Previous);
 }
----------------
Post-commit note, to be considered e.g. when extending sinkings further: seems more logical to start with "if (allUsesDominatedBy(Phi, Previous)) return true; // We already are good w/o sinking", then try to sink with "if (Phi->hasOneUse()) {...}" and finally return false if sinking failed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69228/new/

https://reviews.llvm.org/D69228