[PATCH] D69747: [IPConstantProp][NFCI] Improve and modernize tests

Sat Nov 2 14:27:35 PDT 2019

fhahn added a comment.

In D69747#1731347 <https://reviews.llvm.org/D69747#1731347>, @davide wrote:

> This patch looks good to me.
>
> Now, on the more general discussion. There are some cases that are caught by IPCP [but not IPSCCP]. We can craft examples, if we want, but it's unclear how often they happen in practice. 
>  Having IPCP in tree doesn't seem to be a huge maintenance burden. OTOH, the algorithm is extremely naive and the pass isn't used anywhere, so if somebody wants to remove it, I wouldn't have any objections.

Interesting! That's unfortunate, with the pass being disabled. I'll try to take a look at those when I have a bit of time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69747/new/

https://reviews.llvm.org/D69747