[PATCH] D69747: [IPConstantProp][NFCI] Improve and modernize tests

Sat Nov 2 14:09:30 PDT 2019

jdoerfert added a comment.

In D69747#1731333 <https://reviews.llvm.org/D69747#1731333>, @fhahn wrote:

> It seems some of those files test IPSCCP while others test the IPConstantPropagation pass. Having them both in there is a bit confusing. I think most IPSCCP tests live in test/Transforms/SCCP, which they share the code with. It might be worth to move the IPSCCP tests from IPConstantPropagation to test/Transforms/SCCP or create a new IPSCCP test directory.

I don't mind either way. Do you want me to do it in this commit or do it after?

> And FWIW, I think we might want to consider removing the IPConstantPropagation pass, because it looks like it is not used in any pipelines and IPSCCP is more powerful.

Agreed, see: https://reviews.llvm.org/D69656#1728773

---

Any comments wrt. the changes I made?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69747/new/

https://reviews.llvm.org/D69747