[llvm] 505c4da - isImmPCRel/isImmSigned - both functions should return bool not unsigned. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 2 14:04:39 PDT 2019


Author: Simon Pilgrim
Date: 2019-11-02T21:04:07Z
New Revision: 505c4dabe2fe8fc693c740de4611f58baa11b712

URL: https://github.com/llvm/llvm-project/commit/505c4dabe2fe8fc693c740de4611f58baa11b712
DIFF: https://github.com/llvm/llvm-project/commit/505c4dabe2fe8fc693c740de4611f58baa11b712.diff

LOG: isImmPCRel/isImmSigned - both functions should return bool not unsigned. NFCI.

Added: 
    

Modified: 
    llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h b/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h
index 6bd6c6cac7df..335127c6d064 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h
@@ -675,7 +675,7 @@ namespace X86II {
 
   /// isImmPCRel - Return true if the immediate of the specified instruction's
   /// TSFlags indicates that it is pc relative.
-  inline unsigned isImmPCRel(uint64_t TSFlags) {
+  inline bool isImmPCRel(uint64_t TSFlags) {
     switch (TSFlags & X86II::ImmMask) {
     default: llvm_unreachable("Unknown immediate size");
     case X86II::Imm8PCRel:
@@ -694,7 +694,7 @@ namespace X86II {
 
   /// isImmSigned - Return true if the immediate of the specified instruction's
   /// TSFlags indicates that it is signed.
-  inline unsigned isImmSigned(uint64_t TSFlags) {
+  inline bool isImmSigned(uint64_t TSFlags) {
     switch (TSFlags & X86II::ImmMask) {
     default: llvm_unreachable("Unknown immediate signedness");
     case X86II::Imm32S:


        


More information about the llvm-commits mailing list