[llvm] 004eb2c - GSYMTest::TestLineTable - check all LT1+LT2 comparisons.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2019-11-02T20:12:58Z
New Revision: 004eb2c8627d484cadb2a7268fdbfd35cddc986c

URL: https://github.com/llvm/llvm-project/commit/004eb2c8627d484cadb2a7268fdbfd35cddc986c
DIFF: https://github.com/llvm/llvm-project/commit/004eb2c8627d484cadb2a7268fdbfd35cddc986c.diff

LOG: GSYMTest::TestLineTable - check all LT1+LT2 comparisons.

PVS Studio was warning about "LT2 < LT2" but really we should be testing all permutations of LT1 and LT2.

Added: 
    

Modified: 
    llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp b/llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp
index 90d8594eec6e..9fd8edf6a107 100644
--- a/llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp
+++ b/llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp
@@ -853,7 +853,9 @@ TEST(GSYMTest, TestLineTable) {
   // Test that two empty line tables are equal and neither are less than
   // each other.
   ASSERT_EQ(LT1, LT2);
+  ASSERT_FALSE(LT1 < LT1);
   ASSERT_FALSE(LT1 < LT2);
+  ASSERT_FALSE(LT2 < LT1);
   ASSERT_FALSE(LT2 < LT2);
 
   // Test that a line table with less number of line entries is less than a