[PATCH] D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/trunk/lib/Target/ARM/ARMCallingConv.td:168
   // Handle all vector types as either f64 or v2f64.
-  CCIfType<[v1i64, v2i32, v4i16, v4f16, v8i8, v2f32], CCBitConvertToType<f64>>,
-  CCIfType<[v2i64, v4i32, v8i16, v8f16, v16i8, v4f32], CCBitConvertToType<v2f64>>,
+  CCIfType<[v1i64, v2i32, v4i16, v4f16, v4f16, v8i8, v2f32], CCBitConvertToType<f64>>,
+  CCIfType<[v2i64, v4i32, v8i16, v8f16, v8f16, v16i8, v4f32], CCBitConvertToType<v2f64>>,
----------------
@dnsampaio @ostannard This introduces duplicate v4f16/v8f16 types which is causing PVS Studio warnings:
```
ARMGenCallingConv.inc	63	err	V501 There are identical sub-expressions 'LocVT == MVT::v4f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	74	err	V501 There are identical sub-expressions 'LocVT == MVT::v8f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	235	err	V501 There are identical sub-expressions 'LocVT == MVT::v4f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	246	err	V501 There are identical sub-expressions 'LocVT == MVT::v8f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	605	err	V501 There are identical sub-expressions 'LocVT == MVT::v4f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	616	err	V501 There are identical sub-expressions 'LocVT == MVT::v8f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	710	err	V501 There are identical sub-expressions 'LocVT == MVT::v4f16' to the left and to the right of the '||' operator.
ARMGenCallingConv.inc	721	err	V501 There are identical sub-expressions 'LocVT == MVT::v8f16' to the left and to the right of the '||' operator.
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60720/new/

https://reviews.llvm.org/D60720