[PATCH] D50930: Move Itanium demangler implementation into a header file and add visitation support.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/include/llvm/Demangle/ItaniumDemangle.h:609
+      assert(FirstChar == SecondChar);
+      ++FirstChar, ++SecondChar;
+    }
----------------
Hi Richard, this code looks suspicious. Is this correct?

PVS warns:
/home/xbolva00/LLVM/llvm-project/llvm/include/llvm/Demangle/ItaniumDemangle.h	620	err	V769 The 'SecondChar' pointer in the '++ SecondChar' expression equals nullptr. The resulting value is senseless and it should not be used.




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50930/new/

https://reviews.llvm.org/D50930