[PATCH] D69556: [CodeGen] Move ARMCodegenPrepare to TypePromotion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 23:43:36 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/TypePromotion.cpp:208
 
   if (auto *Ld = dyn_cast<LoadInst>(V))
     Ty = cast<PointerType>(Ld->getPointerOperandType())->getElementType();
----------------
Are these two lines needed? The pointer element type should match the result type of the load right? Only asking because this code will need to be updated if we ever move to opaque pointers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69556/new/

https://reviews.llvm.org/D69556





More information about the llvm-commits mailing list