[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 1 14:04:52 PDT 2019
delcypher added a comment.
@yln @eugenis Can we do another round of review? I made some slightly different design choices to what was previously discussed. Here's my reasoning:
- `...` is not appended to truncated strings. I thought that might be ambiguous (Is `...` part of the string or is the string truncated?). So instead every time an option gets truncated it prints `(Current Value Truncated: <value>)` rather than `(Current Value: <value>)` which is not ambiguous.
- Due to the above `CurrentValueAsString` keeps its boolean return value but now returning false means truncating occurred.
- Due to implementing the above I discovered I hadn't implemented support in `FlagHandlerInclude`. This is now done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69546/new/
https://reviews.llvm.org/D69546
More information about the llvm-commits
mailing list