[PATCH] D69735: [amdgpu] Fix known bits compuation on `MUL_I24`/`MUL_U24`.

[Michael Liao via Phabricator via llvm-commits]

hliao marked 2 inline comments as done.
hliao added a comment.

In D69735#1730811 <https://reviews.llvm.org/D69735#1730811>, @arsenm wrote:

> What was the symptom of this?


crash as the extra check following that assumes non-zero operands. As all bits are known zero, that results in the conflict finally.



================
Comment at: llvm/test/CodeGen/AMDGPU/computeNumSignBits-mul.ll:163
+; GFX9: v_mov_b32_e32 v0, 0
+; GFX9-NEXT:    s_setpc_b64 s[30:31]
+define i32 @known_bits_mul24() {
----------------
arsenm wrote:
> Drop the return address register
OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69735/new/

https://reviews.llvm.org/D69735