[PATCH] D69688: [builtins] Move X86 common files to a subdirectory

[Yi Kong via Phabricator via llvm-commits]

kongyi added a comment.

In D69688#1730803 <https://reviews.llvm.org/D69688#1730803>, @delcypher wrote:

> @kongyi Hmm we have both `x86_common/floatdixf.c` and `x86_64/floatdixf.c`. I think both `x86_64h_SOURCES` and `x86_64_SOURCES` will end up with both `x86_common/floatdixf.c` and  `x86_64/floatdixf.c` due to...
>
>   set(x86_64h_SOURCES ${x86_64h_SOURCES} ${x86_ARCH_SOURCES})
>   set(x86_64_SOURCES ${x86_64_SOURCES} ${x86_ARCH_SOURCES})
>
>
> I don't think the filtering algorithm (removing generic builtin implementations in favour of architecture specific implementations) handles this case. Due to both sources being in sub directories they are considered to both be architecture specific implementations.
>  If I'm right it should mean that with this patch running `ninja check-builtins` should result in an error due to me relanding `23a33d450b9a426eae7094b16472f8a51fb5488a`, i.e. when lit runs we should detect that there is more than one implementation of `floatdixf`.
>
> Could you check this?


Ah, I didn't notice this... Let me rework the patch to fix this.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69688/new/

https://reviews.llvm.org/D69688