[PATCH] D69679: [AMDGPU] Add amdgpu-promote-pointer-kernargs pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D69679#1729684 <https://reviews.llvm.org/D69679#1729684>, @yaxunl wrote:

> In D69679#1729466 <https://reviews.llvm.org/D69679#1729466>, @tra wrote:
>
> > @arsenm has a point.  We can do it in clang, and it seems to be a better long-term solution compared to patching-up the inputs' AS that we've done for NVPTX and, now, AMDGPU.
> >
> > If we do want to change the IR-level calling convention for the kernels, clang would not be the only place that would need to adapt to that change. We will need to think about transitioning existing external users, too (e.g. XLA in TensorFlow & JAX, julia). We may need to keep the promote-pointers-to-global-AS pass around for a while until the LLVM users have a chance to change their code to pass pointers using correct address space.
>
>
> AMDGPU backend is able to handle pointer type kernel arg in default address space. This pass is more for performance.


Yes, but it’s ultimately a workaround for not producing the correct pointer type in the first place. It adds more passes and intermediate instructions that could be avoided


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69679/new/

https://reviews.llvm.org/D69679