[PATCH] D69676: [WinCFG] Handle constant casts carefully in .gfids emission
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 1 13:04:51 PDT 2019
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/CodeGen/AsmPrinter/WinCFGuard.cpp:55
+ const User *FnUser = U.getUser();
+ // FIXME: Should CFG protect indirectbr as well?
+ if (isa<BlockAddress>(FnUser))
----------------
Even if we did decide CFG should protect indirectbr, the target would be the block in question, not the function. So this FIXME isn't really in the right place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69676/new/
https://reviews.llvm.org/D69676
More information about the llvm-commits
mailing list