[llvm] add76dd - [X86] Fix -DBUILD_SHARED_LIBS=on builds after D69568/llvmorg-10-init-8877-g3a399c09878

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2019-11-01T09:51:17-07:00
New Revision: add76dd3cbebc92f1862705d4432ba0f65db6286

URL: https://github.com/llvm/llvm-project/commit/add76dd3cbebc92f1862705d4432ba0f65db6286
DIFF: https://github.com/llvm/llvm-project/commit/add76dd3cbebc92f1862705d4432ba0f65db6286.diff

LOG: [X86] Fix -DBUILD_SHARED_LIBS=on builds after D69568/llvmorg-10-init-8877-g3a399c09878

In -DBUILD_SHARED_LIBS=on builds, a component must specify its direct dependencies to satisfy -Wl,-z,defs (added by llvm/modules/HandleLLVMOptions.cmake).

Core is a direct dependency via transitive header inclusion:

  ld.lld: error: undefined symbol: llvm::LLVMContext::LLVMContext()
  >>> referenced by MachineSizeOptsTest.cpp
  >>>               unittests/Target/X86/CMakeFiles/X86Tests.dir/MachineSizeOptsTest.cpp.o:(testing::internal::TestFactoryImpl<(anonymous namespace)::MachineSizeOptsTest_Test_Test>::CreateTest())

MC is a direct dependency via transitive header inclusion:

  ld.lld: error: undefined symbol: llvm::MCTargetOptions::MCTargetOptions()
  >>> referenced by MachineSizeOptsTest.cpp
  >>>               unittests/Target/X86/CMakeFiles/X86Tests.dir/MachineSizeOptsTest.cpp.o:((anonymous namespace)::MachineSizeOptsTest::SetUp())

Added: 
    

Modified: 
    llvm/unittests/Target/X86/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Target/X86/CMakeLists.txt b/llvm/unittests/Target/X86/CMakeLists.txt
index 4676094cb9cf..5763f4f5edb8 100644
--- a/llvm/unittests/Target/X86/CMakeLists.txt
+++ b/llvm/unittests/Target/X86/CMakeLists.txt
@@ -6,6 +6,8 @@ include_directories(
 set(LLVM_LINK_COMPONENTS
   Analysis
   CodeGen
+  Core
+  MC
   MIRParser
   Support
   Target