[PATCH] D69500: [X86] NFC: Convert LLVM command-line flag to target attribute

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 09:39:07 PDT 2019


davezarzycki added a comment.

In D69500#1730264 <https://reviews.llvm.org/D69500#1730264>, @craig.topper wrote:

> I still don’t understand why we’re not just renaming the existing flag? What are you planning to connect the old flag to?


I didn't remove it because it seemed like information would be "lost". Said differently, I didn't know that some AMD CPUs have fast partial updates too.

I made a quick attempt at using the "fast partial" flag so that it wouldn't be left unused, but I got distracted. (For example using SSE move instructions instead of VINSERT*)

And yes, the -target-feature flag can be reached from the driver via -Xclang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69500/new/

https://reviews.llvm.org/D69500





More information about the llvm-commits mailing list