[PATCH] D69497: [PowerPC] Fix MI peephole optimization for splats

Colin Samples via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 08:12:31 PDT 2019


vddvss updated this revision to Diff 227450.
vddvss edited the summary of this revision.
vddvss added a comment.

See attached for an updated diff. This also changes the name of `FeedImmed` to `DefImmed` to be congruent with `DefReg[12]`.

No worries on the continued revisions. I want to to thank you all for your suggestions--they have definitely made the original patch a lot better.

Also, I noticed in the `case PPC::XXPERMDI:` block there are a couple of nested `if`s without `else`s and checks on `if`s that could simplified by converted to early `break`s, albeit at the cost of polluting `git blame` with whitespace differences. Let me know if you are interested in a separate patch to clean some of that up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69497/new/

https://reviews.llvm.org/D69497

Files:
  llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
  llvm/test/CodeGen/PowerPC/mi-peephole-splat.ll
  llvm/test/CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69497.227450.patch
Type: text/x-patch
Size: 18640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191101/3c41c965/attachment.bin>


More information about the llvm-commits mailing list