[PATCH] D69709: [yaml2obj][WIP] - Add a way to describe the custom data that is not part of an output section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 07:21:46 PDT 2019


grimar added a comment.

> I also don't think an Offset field is a good idea unless we only allow them to be increasing (i.e. if a section appears later in the list with an Offset lower than the end of the previous section, it's an error).

I think it is correct to error out in this case. It should be OK to only allow describing sections in the order they will be written to the output.
Having a error might even help, e.g. when you add a section you can forget that it requires an entry in a section header and that shifts things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69709/new/

https://reviews.llvm.org/D69709





More information about the llvm-commits mailing list