[llvm] fc98907 - [SLP] avoid 'tmp' value name conflict with auto-generated CHECK script; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 1 06:28:41 PDT 2019
Author: Sanjay Patel
Date: 2019-11-01T09:27:35-04:00
New Revision: fc98907535c0a41747e89093d45a888f54af1800
URL: https://github.com/llvm/llvm-project/commit/fc98907535c0a41747e89093d45a888f54af1800
DIFF: https://github.com/llvm/llvm-project/commit/fc98907535c0a41747e89093d45a888f54af1800.diff
LOG: [SLP] avoid 'tmp' value name conflict with auto-generated CHECK script; NFC
The script uses 'TMP#' as its substitute for nameless values,
so if a test already contains 'tmp#' *named* values, then
there could be trouble. We should probably just fix the
script to avoid this problem going forward, but it's easy
enough to change a test too (and explicitly naming variables
'tmp' is always a sad choice).
Added:
Modified:
llvm/test/Transforms/SLPVectorizer/X86/PR35777.ll
Removed:
################################################################################
diff --git a/llvm/test/Transforms/SLPVectorizer/X86/PR35777.ll b/llvm/test/Transforms/SLPVectorizer/X86/PR35777.ll
index 4a403e7b9a3f..53215d6121fd 100644
--- a/llvm/test/Transforms/SLPVectorizer/X86/PR35777.ll
+++ b/llvm/test/Transforms/SLPVectorizer/X86/PR35777.ll
@@ -4,7 +4,7 @@
@global = local_unnamed_addr global [6 x double] zeroinitializer, align 16
define { i64, i64 } @patatino(double %arg) {
-; CHECK-LABEL: @patatino(
+; CHECK-LABEL: define {{[^@]+}}@patatino(
; CHECK-NEXT: bb:
; CHECK-NEXT: [[TMP0:%.*]] = load <2 x double>, <2 x double>* bitcast ([6 x double]* @global to <2 x double>*), align 16
; CHECK-NEXT: [[TMP1:%.*]] = load <2 x double>, <2 x double>* bitcast (double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 2) to <2 x double>*), align 16
@@ -17,29 +17,29 @@ define { i64, i64 } @patatino(double %arg) {
; CHECK-NEXT: [[TMP8:%.*]] = fptosi <2 x double> [[TMP7]] to <2 x i32>
; CHECK-NEXT: [[TMP9:%.*]] = sext <2 x i32> [[TMP8]] to <2 x i64>
; CHECK-NEXT: [[TMP10:%.*]] = extractelement <2 x i64> [[TMP9]], i32 0
-; CHECK-NEXT: [[TMP16:%.*]] = insertvalue { i64, i64 } undef, i64 [[TMP10]], 0
+; CHECK-NEXT: [[T16:%.*]] = insertvalue { i64, i64 } undef, i64 [[TMP10]], 0
; CHECK-NEXT: [[TMP11:%.*]] = extractelement <2 x i64> [[TMP9]], i32 1
-; CHECK-NEXT: [[TMP17:%.*]] = insertvalue { i64, i64 } [[TMP16]], i64 [[TMP11]], 1
-; CHECK-NEXT: ret { i64, i64 } [[TMP17]]
+; CHECK-NEXT: [[T17:%.*]] = insertvalue { i64, i64 } [[T16]], i64 [[TMP11]], 1
+; CHECK-NEXT: ret { i64, i64 } [[T17]]
;
bb:
- %tmp = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 0), align 16
- %tmp1 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 2), align 16
- %tmp2 = fmul double %tmp1, %arg
- %tmp3 = fadd double %tmp, %tmp2
- %tmp4 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 4), align 16
- %tmp5 = fadd double %tmp4, %tmp3
- %tmp6 = fptosi double %tmp5 to i32
- %tmp7 = sext i32 %tmp6 to i64
- %tmp8 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 1), align 8
- %tmp9 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 3), align 8
- %tmp10 = fmul double %tmp9, %arg
- %tmp11 = fadd double %tmp8, %tmp10
- %tmp12 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 5), align 8
- %tmp13 = fadd double %tmp12, %tmp11
- %tmp14 = fptosi double %tmp13 to i32
- %tmp15 = sext i32 %tmp14 to i64
- %tmp16 = insertvalue { i64, i64 } undef, i64 %tmp7, 0
- %tmp17 = insertvalue { i64, i64 } %tmp16, i64 %tmp15, 1
- ret { i64, i64 } %tmp17
+ %t = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 0), align 16
+ %t1 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 2), align 16
+ %t2 = fmul double %t1, %arg
+ %t3 = fadd double %t, %t2
+ %t4 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 4), align 16
+ %t5 = fadd double %t4, %t3
+ %t6 = fptosi double %t5 to i32
+ %t7 = sext i32 %t6 to i64
+ %t8 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 1), align 8
+ %t9 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 3), align 8
+ %t10 = fmul double %t9, %arg
+ %t11 = fadd double %t8, %t10
+ %t12 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @global, i64 0, i64 5), align 8
+ %t13 = fadd double %t12, %t11
+ %t14 = fptosi double %t13 to i32
+ %t15 = sext i32 %t14 to i64
+ %t16 = insertvalue { i64, i64 } undef, i64 %t7, 0
+ %t17 = insertvalue { i64, i64 } %t16, i64 %t15, 1
+ ret { i64, i64 } %t17
}
More information about the llvm-commits
mailing list