[PATCH] D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D69027#1729906 <https://reviews.llvm.org/D69027#1729906>, @krisb wrote:

> What do you think?


I think we need to have(for Statistics.cpp):

ScopeBytesCovered -> includes all scope bytes intersected with variable loc list. For all variables and parameters.
ScopeBytesFromFirstDefinition -> renamed into ScopeBytes, and includes all scope bytes counted for each variable separately. For all variables and parameters.

ParamScopeBytesCovered -> same as ScopeBytesCovered but for parameters only.
ParamScopeBytesFromFirstDefinition -> same as ScopeBytes but for parameters only.

VarScopeBytesCovered -> same as ScopeBytesCovered but for variables only.
VarScopeBytesFromFirstDefinition -> same as ScopeBytes but for variables only.

buckets are calculated against not trimmed(not adjusted) scope(that is the same value which is calculated for ScopeBytes for single variable).

documentation is updated accordingly.

if we would like to calculate coverage for trimmed/adjusted/approximate_variable's_life variable scope then we could add additional statistic fields.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69027/new/

https://reviews.llvm.org/D69027