[PATCH] D69671: [llvm-readobj] Change errors to warnings for symbol section name dumping

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 1 04:24:26 PDT 2019


jhenderson updated this revision to Diff 227417.
jhenderson marked 6 inline comments as done.
jhenderson added a comment.

Address review comments:

- call WarningHandler inline
- reflow tests
- handle unhandled Error

Also added --implicit-check-not=warning to a couple of checks to show that the warnings are uniqued properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69671/new/

https://reviews.llvm.org/D69671

Files:
  llvm/test/Object/invalid.test
  llvm/test/tools/llvm-readobj/elf-section-symbols.test
  llvm/test/tools/llvm-readobj/elf-symbol-shndx.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69671.227417.patch
Type: text/x-patch
Size: 17585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191101/14bae587/attachment.bin>


More information about the llvm-commits mailing list