[PATCH] D14829: [SLP] Vectorize gather-like idioms ending at non-consecutive loads.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp:3538
+        continue;
+      if (!isValidElementType(Idx->getType()))
+        continue;
----------------
Post-commit review:

I'm 99.9% sure this is wrong.
You are checking the type *of an gep index*,
not the type of the value the gep will produce.
I don't see why you'd care about gep index type.
But you certainly care about resulting type and it's not checked.

You want `if (!isValidElementType(GEP->getResultElementType()))`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D14829/new/

https://reviews.llvm.org/D14829