[PATCH] D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.


================
Comment at: lib/CodeGen/MachineVerifier.cpp:2328
+              "%.bb." + Twine((*PrI)->getNumber());
+            report(Msg.str().c_str(), &MBB);
+          }
----------------
qcolombet wrote:
> The patterns elsewhere in the verifier use:
> report("simple message")
> errs() << "fancy message" << WithVariable;
Ah, thanks :-)



================
Comment at: test/MachineVerifier/live-ins-01.mir:9
+  define i32 @f2(i32 %a, i32 %b)  { ret i32 %a }
+...
+---
----------------
qcolombet wrote:
> You can get rid of this whole section if you remove the reference to the ir in the machine code (highlighted in the next comment).
nice


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68267/new/

https://reviews.llvm.org/D68267