[PATCH] D69670: [NFC][llvm-readobj] Split getSectionIndexName function into two
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 1 01:33:47 PDT 2019
grimar accepted this revision.
grimar added a comment.
LGTM with a nit.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:878
+ const ELFFile<ELFT> *Obj = ObjF->getELFFile();
+ Expected<const typename ELFT::Shdr *> SecOrErr =
+ Obj->getSection(SectionIndex);
----------------
Seems you should be able to `typename ELFT::Shdr` -> `Elf_Shdr` here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69670/new/
https://reviews.llvm.org/D69670
More information about the llvm-commits
mailing list