[PATCH] D69669: [NFC][llvm-readobj] Pull common code into a helper

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LGTM. Thoughs about possible futher refactoring is inline.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5445
+void LLVMStyle<ELFT>::printSymbolSection(const Elf_Sym *Symbol,
+                                         const Elf_Sym *First) {
+  unsigned SectionIndex = 0;
----------------
A side note: I think we should probably get rid of `First` and pass the symbols index instead.
Seems `First` is used only for that purpose, but it is probably a bit confusing to see 2 `Elf_Sym` arguments
in a functions called like `printSymbolSection`, i.e. its name kind of assumes a single symbol, though arguments list has 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69669/new/

https://reviews.llvm.org/D69669