[PATCH] D69698: AMDGPU: Add default denormal mode to MachineFunctionInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 21:14:52 PDT 2019


arsenm added a comment.

In D69698#1729744 <https://reviews.llvm.org/D69698#1729744>, @rampitec wrote:

> As far as I understand this changes the default. Currently default depends on the ASIC and its ability to support denorms fast. I think we want to keep it this way.


This is a decision for the frontend. Undecorated IR functions need to be the conservatively correct default. Currently clang puts the subtarget feature on functions (except in the device library build). Eventually that will be replaced with a function attribute. Currently with the default of no denormals set by the backend, the library is miscompiled whenever it's not inlined


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69698/new/

https://reviews.llvm.org/D69698





More information about the llvm-commits mailing list