[PATCH] D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:269
+
+Add an offset to a pointer.
+
----------------
rovka wrote:
> I think it's ok for some of the other instructions to have a more summary description and no code block at the moment, but it would be nice to brush this one up a bit since it's different from what people might expect.
I've added a code block and an explicit mention that the offset is in addressable units (usually bytes) but I'm not sure what else to add at the moment.

When I get a chance I'm going to propose renaming this to G_PTR_ADD on the list


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:273
+
+  This instruction is misleadingly named. It bears little resemblence to
+  :ref:`i_getelementptr`.
----------------
rovka wrote:
> I'm not a native speaker but I think it's resembl**a**nce.
You're right, I just don't have spell checking enabled in vim :-)


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:418
+
+NaN-propagating minimum that also treat -0.0 as less than 0.0. While
+FMINNUM_IEEE follow IEEE 754-2008 semantics, FMINIMUM follows IEEE 754-2018
----------------
rovka wrote:
> Typo: treat
I'm not sure what you mean on this one. It looks fine to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69545/new/

https://reviews.llvm.org/D69545