[PATCH] D69679: [AMDGPU] Add amdgpu-promote-pointer-kernargs pass
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 31 15:21:05 PDT 2019
arsenm added a comment.
In D69679#1729474 <https://reviews.llvm.org/D69679#1729474>, @arsenm wrote:
> Another issue I'm concerned about is the interaction with the (still out of tree), hacky pass to handle kernels calling other kernels as a normal function for OpenCL. This is another area that clang needs codegen work to really emit the right IR/ABI for kernels. If we blindly rewrite arguments with this hack in place, we risk incorrectly rewriting the callable function form
I think OpenCL still disallows generic pointer arguments to kernels, although I wouldn't like to rely on this fact for correctness
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69679/new/
https://reviews.llvm.org/D69679
More information about the llvm-commits
mailing list