[PATCH] D69682: [cmake] Remove SVN support from VersionFromVCS.cmake

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 15:02:28 PDT 2019


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:51
 
 function(get_source_info path revision repository)
+  get_source_info_git("${path}" revision_info repository_info)
----------------
This function just forwards to `get_source_info_git` now, so we could just delete it and rename `get_source_info_git` to `get_source_info`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69682/new/

https://reviews.llvm.org/D69682





More information about the llvm-commits mailing list