[PATCH] D69313: Handle more crt*.o filename variants.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 14:34:17 PDT 2019


MaskRay added a comment.

You may install the PHP (yes..) tool arcanist. I usually do:

  # say you are in branch foobar
  % arc diff 'HEAD^' # answer yes, to create a differential (Dxxxxx)
  # get approved
  % arc amend  # will amend your git description with a `Reviewed By:` line. I usually delete `Subscribers:` and `Tags:` lines because they are really useless. Make sure to keep the `Differential Revision:` line.
  % git rebase --onto origin/master 'HEAD^' HEAD
  % ninja -C Release check-lld-elf  # Make sure tests are still good after the rebase.
  
  % git checkout master
  % git merge --ff foobar
  % git push

The `Differential Revision:` line is important. It associates a git commit with a differential and causes the differential to be closed automatically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69313/new/

https://reviews.llvm.org/D69313





More information about the llvm-commits mailing list