[PATCH] D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries

Thu Oct 31 14:34:15 PDT 2019

jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.

In D59883#1728641 <https://reviews.llvm.org/D59883#1728641>, @pjeeva01 wrote:

> Given that the setLibcallName approach to lowering massv calls involves non-trivial extension to both target-independent and PPC-specific files,

OK, yes, it is a non-trivial work.

LGTM for now considering the amount of work needed for setLibcallName.

================
Comment at: llvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp:109
+  std::string MASSVEntryName = createMASSVFuncName(Func, Subtarget);
+  FunctionCallee FCache = M.getOrInsertFunction(
+      MASSVEntryName, Func.getFunctionType(), Func.getAttributes());
----------------
`FCache`? Typo?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59883/new/

https://reviews.llvm.org/D59883