[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 13:35:16 PDT 2019


thakis added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1095
+                              ? cl::TokenizeWindowsCommandLine
+                              : cl::TokenizeGNUCommandLine,
+                          Argv);
----------------
If we do this, we almost certainly want to add an --rsp-quoting flag like clang-cl and lld-link have, for cross builds targeting windows on linux.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665





More information about the llvm-commits mailing list