[PATCH] D69416: [Examples] Add IRTransformations directory to examples.

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 10:29:51 PDT 2019


andwar added a comment.

Includes are missing in `SimplifyCFG.h`:

  cmake -G Ninja -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release   -DLLVM_USE_NEWPM=On -DLLVM_BUILD_EXAMPLES=On ../../llvm/
  (...)
  ninja opt
  (...)
  /work/llvm-project/llvm/examples/IRTransforms/SimplifyCFG.h:15:1: error: unknown type name 'FunctionPass'
  FunctionPass *createSimplifyCFGPass();
  ^
  /work/llvm-project/llvm/examples/IRTransforms/SimplifyCFG.h:17:40: error: unknown type name 'PassRegistry'
  void initializeSimplifyCFGLegacyPMPass(PassRegistry &);
                                         ^



================
Comment at: llvm/test/Examples/IRTransforms/SimplifyCFG/tut-simplify-cfg-blockaddress.ll:16
+
+if.then:
+  ret i8* null
----------------
[nit] For this example the names of BBs are rather irrelevant, but `if.then` (or `if.else`) could suggest otherwise. Maybe worth renaming? Just a thought.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69416/new/

https://reviews.llvm.org/D69416





More information about the llvm-commits mailing list