[PATCH] D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Looks sensible to me.



================
Comment at: lib/CodeGen/MachineVerifier.cpp:2328
+              "%.bb." + Twine((*PrI)->getNumber());
+            report(Msg.str().c_str(), &MBB);
+          }
----------------
The patterns elsewhere in the verifier use:
report("simple message")
errs() << "fancy message" << WithVariable;


================
Comment at: test/MachineVerifier/live-ins-01.mir:9
+  define i32 @f2(i32 %a, i32 %b)  { ret i32 %a }
+...
+---
----------------
You can get rid of this whole section if you remove the reference to the ir in the machine code (highlighted in the next comment).


================
Comment at: test/MachineVerifier/live-ins-01.mir:15
+body:             |
+  bb.0 (%ir-block.0):
+    liveins: $r2l, $r3l
----------------
Remove the part in parentheses here.


================
Comment at: test/MachineVerifier/live-ins-01.mir:22
+
+  bb.1 (%ir-block.0):
+    liveins: $cc
----------------
Ditto.


================
Comment at: test/MachineVerifier/live-ins-02.mir:35
+
+...
----------------
Could you add a test case with at least one basic block with more than one predecessor.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68267/new/

https://reviews.llvm.org/D68267