[PATCH] D69547: DAG: Add function context to isFMAFasterThanFMulAndFAdd

Thu Oct 31 08:19:17 PDT 2019

cameron.mcinally added a comment.
Herald added a subscriber: wuzish.

Is `isFMAFasterThanFMulAndFAdd`'s `MachineFunction` argument currently used? Or is that coming in a follow-up Diff? I might have missed it...

================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2549
     return false;
   }

----------------
Agreed, the AArch64 requirements are ugly.

It doesn't look like the AArch64 hooks need the Function arg. Could we just make the MachineFunction argument optional; to consolidate the two functions? E.g.

```
  virtual bool isFMAFasterThanFMulAndFAdd(EVT, const MachineFunction &MF = nullptr) const {
```

Or is that not allowed with some virtual functions? I can't remember the details...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69547/new/

https://reviews.llvm.org/D69547