[PATCH] D69066: Add support for intrinsic llvm.ppc.eieio

Thu Oct 31 08:00:03 PDT 2019

anil9 added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:2207
+                           "eieio", IIC_LdStLoad, []>;
+
 def : Pat<(int_ppc_sync),   (SYNC 0)>, Requires<[HasSYNC]>;
----------------
lei wrote:
> This used to be under `PowerPC Instructions used for assembler/disassembler only`.  Is this no longer true?   You seem to have moved this into `PPC32 Store Instructions` section.  What does this intrinsic do?
> 
> We generally don't move unrelated code around.   Maybe keep this where it was and add your new def under `PowerPC Assembler Instruction Aliases`?
We are exposing it as an intrinsic, so I think it is not just for assembler/disassembler only so should not be in the previous place anymore.

It is a form of barrier that acts on only load and stores related to data not instructions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69066/new/

https://reviews.llvm.org/D69066