[PATCH] D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 31 05:47:11 PDT 2019
avl added a comment.
> I see the primary value of this statistic to allow us to see change — then a human has to make judgement what that change means.
That is exactly the reason why I propose to drop calculation of OffsetToFirstDefinition. For the already discussed example, currently visible change would be 100%->100% For the case without OffsetToFirstDefinition there would be something like 20%->30% which makes change visible.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69027/new/
https://reviews.llvm.org/D69027
More information about the llvm-commits
mailing list