[PATCH] D69647: [Attributor] Really use the executed-context

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 05:17:33 PDT 2019


uenoku accepted this revision.
uenoku added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1673-1678
+  if (isa<CastInst>(I))
+    TrackUse = true;
+  if (auto *GEP = dyn_cast<GetElementPtrInst>(I))
+    if (GEP->hasAllZeroIndices() ||
+        (GEP->isInBounds() && GEP->hasAllConstantIndices()))
+      TrackUse = true;
----------------
It might be better to insert early returns to these blocks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69647/new/

https://reviews.llvm.org/D69647





More information about the llvm-commits mailing list