[PATCH] D69610: Fix compiler-rt build on macOS without XCode

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 04:49:32 PDT 2019


arichardson marked 3 inline comments as done.
arichardson added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:10
 # the current Xcode.
 function(find_darwin_sdk_dir var sdk_name)
   set(DARWIN_${sdk_name}_CACHED_SYSROOT "" CACHE STRING "Darwin SDK path for SDK ${sdk_name}.")
----------------
delcypher wrote:
> yln wrote:
> > Would this function benefit from a similar change?
> Yes we should but perhaps as a separate patch?
See D69659


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69610/new/

https://reviews.llvm.org/D69610





More information about the llvm-commits mailing list