[PATCH] D69650: [ELF] Suggest an arbitrary C++ overload as an alternative spelling

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 04:21:37 PDT 2019


peter.smith added a comment.

Thanks for the update.



================
Comment at: lld/ELF/Relocations.cpp:707
+         len == ref.size() && def.take_front(len) == ref;
+}
+
----------------
I think it will be worth defining how long is too long for a better error message, then testing some large programs with the full demangling to see if it makes a difference that anyone would be able to perceive and get frustrated with. I'd be happy with even a few seconds for a better error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69650/new/

https://reviews.llvm.org/D69650





More information about the llvm-commits mailing list