[PATCH] D69607: Add a feature to explain why some file gets included to the linker's output

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/ELF/Explain.cpp:157
+
+  if (!seen.insert(sym.file).second)
+    return;
----------------
ruiu wrote:
> MaskRay wrote:
> > We can make edges a superset of specialEdges, then we can just delete `seen` and use `edges.try_emplace(...)` here.
> We probably could but looks like it also makes sense to keep them distinctive sets, so I'm leaning towards not doing that.
It's not a strong preference, but error is perhaps better than printing it out as a non-error message? When the control reaches here, something is wrong from the user's perspective.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69607/new/

https://reviews.llvm.org/D69607