[PATCH] D68996: [AArch64][SVE] Spilling/filling of SVE callee-saves.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:848
+  case AArch64::LDR_PXI:
+    return !I->getOperand(1).isFI();
+  }
----------------
ostannard wrote:
> I'm worried that this will start matching load/store instructions which are not part of the prologue/epilogue once we start emitting them. Some calls to this function also check the `FrameSetup`/`FrameDestroy` flags, but not all of them. Maybe we could check that the base register is `SP`, this is run before frame index lowering so only prologue/epilogue code should be referring directly to SP at this point?
Some code related to call lowering can also directly reference sp.  Better to rely on FrameSetup/FrameDestroy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68996/new/

https://reviews.llvm.org/D68996