[PATCH] D67572: [SVFS] SearchVFSystem interface (WIP).

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D67572#1727678 <https://reviews.llvm.org/D67572#1727678>, @fpetrogalli wrote:

> In D67572#1725229 <https://reviews.llvm.org/D67572#1725229>, @simoll wrote:
>
> > In D67572#1670052 <https://reviews.llvm.org/D67572#1670052>, @fpetrogalli wrote:
> >
> > > One more thing: in the RFC we decided to pass the `CallInst` to the methods of the class instead of the `Function` definition, because we wanted to make the attribute `vector-function-abi-variant` to be local to the call site, not the declaration. Unfortunately, I couldn't find a way to attach an attribute to a `CallInst`. Is this the case? Or have I missed somethign around `Instruction`s and attributes?
> >
> >
> > Could you add it to the attribute list of the call site at `AttributeList::FunctionIndex`?
>
>
> Thank you for the suggestion. I have looked into this but it seems that adding an attribute to a CallInst in the `AttributeList::FunctionIndex` has the effect of juts adding the attribute to the function being called.


The attribute lists are different. You might have added it to the function one but you can add it to the CallBase one as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572