[PATCH] D69013: [AArch64][X86] Don't assume __powidf2 is available on Windows.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581-582
+  if (!TLI.getLibcallName(LC)) {
+    // Some targets don't have a powi libcall; use pow instead.
+    report_fatal_error("Don't know how to soften fpowi to fpow");
+  }
----------------
efriedma wrote:
> compnerd wrote:
> > rnk wrote:
> > > Can this be made into an assert or non-fatal error by DAG->getContext().emitError("..."), and then returning the input SDNode unmodified?
> > I would rather have this be a `report_fatal_error` or the `DAG->getContext().emitError` + `return SDNode()`.  Please don't make this into an assertion, I know too many people who tend to use the -Asserts variant of the toolchain.
> I think this is impossible to hit at the moment; there's no such thing as soft-float Windows.  I just didn't want to make it an llvm_unreachable in case someone adds a new target where it might be relevant.
> 
> Or I could implement it without a testcase, I guess; it's not hard.
@efriedma yeah, I think that both of us are in agreement, I just meant that leave this as is, or use the reporting error as @rnk suggested, but don't make it an `assert` is all.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69013/new/

https://reviews.llvm.org/D69013