[PATCH] D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D69584#1727541 <https://reviews.llvm.org/D69584#1727541>, @jmorse wrote:

> LGTM; I wonder whether there are other places in the register allocator that need to notify LDV of what's happening, but I don't know enough about allocators.


RAGreedy is calling splitRegister is several other places already. This was at least one place in the code where it seemed to be missing (I've kind of quickly browsed through other uses of LiveRangeEdit in RAGreedy and at other places it seemed like we ended up in calls to splitRegister sooner or later). All those calls dates back to 2013 or something (maybe it was 2011), and maybe the call to InlineSpiller here didn't even exist back in those days.

I don't know much about RABasic, but it might have similar problems (at least it got a pass dependency toward LiveDebugVariables). The PR was for RAGreedy so I simply focused on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69584/new/

https://reviews.llvm.org/D69584