[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 11:51:26 PDT 2019


hubert.reinterpretcast added a comment.

In D69356#1727484 <https://reviews.llvm.org/D69356#1727484>, @beanz wrote:

> We should not be adding more variables that are passed around by CMake's scope inheritance. Instead if we need to change this we should do it correctly.


Just to clarify, the actions to take are to restore `LLVM_NO_DEAD_STRIP` in order to support other uses and then to replace its use as an internal variable? Given that direction, I agree the first course of action is to revert this patch and then to pursue a patch to do the replacement separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69356/new/

https://reviews.llvm.org/D69356





More information about the llvm-commits mailing list