[PATCH] D69616: [FPEnv] The inliner shouldn't mix strictfp and non-strictfp functions.

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 11:31:46 PDT 2019


kpn marked an inline comment as done.
kpn added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2039
+  // overrides the AlwaysInline attribute!
+  // This should be improved at some point.
+  if (Call.getCaller()->hasFnAttribute(Attribute::StrictFP) !=
----------------
craig.topper wrote:
> Should this be a FIXME or TODO so it stands out?
Sure, that makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69616/new/

https://reviews.llvm.org/D69616





More information about the llvm-commits mailing list