[PATCH] D69275: Add constrained int->FP intrinsics

Wed Oct 30 11:22:01 PDT 2019

kpn marked an inline comment as done.
kpn added inline comments.

================
Comment at: llvm/test/CodeGen/X86/fp-intrinsics.ll:423
+; CHECK-LABEL: @f31
+; CHECK: call double @llvm.experimental.constrained.sitofp
+define double @f31() #0 {
----------------
craig.topper wrote:
> kpn wrote:
> > craig.topper wrote:
> > > This check line is for IR, but this is an assembly test. CHECK isn't a valid check-prefix for this file. Which also means all of the CHECK-LABEL lines are broken in the existing tests aren't doing anything
> > Ouch, yeah, that error is all over this file. How about I fix it for the new changes here and then fix the rest in another ticket?
> What is the expected behavior here? We seem to doing some emulation of the operation instead of using the conversion instruction we have with SSE2.
That may be an artifact of of the getOperationAction()/getStrictFPOperationAction() issue that I found after the rearranging Cameron asked for. I'm looking into it now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69275/new/

https://reviews.llvm.org/D69275